Re: [PATCH] PCI: Fix racing for pci device removing via sysfs

[Bjorn Helgaas]

On Fri, Apr 26, 2013 at 2:20 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Fri, Apr 26, 2013 at 9:28 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> This is a gross hack.  Iterating through all known pci_devs to see if
>> this one still exists?
>>
>> I reproduced the original problem, applied this patch, and verified
>> that it avoids the original crash.
>>
>> However, it's still incorrect because now you're looking at pdev after
>> it's been freed. With CONFIG_SLUB_DEBUG_ON=y, the removal still causes
>> a crash in remove_callback().
>>
>
> Yes, there is small window, that could have bus and dev get freed...
>
> Please check attached that should address your concerns.

You can't be serious.  This is a disgusting mess.  Checking a list
pointer for LIST_POISON1?  As far as I'm concerned, this is a waste of
my time.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/