VIA velocity network driver
From: Tony Prisk
Date: Sat Apr 27 2013 - 01:30:21 EST
I would like to add support to this driver for platform devices as found
on VIA's APC8750 board. At the moment, I have a standalone platform
version that works fine, but wanted to ask a few questions before
sending a patch to merge this code into one driver.
The current driver is for PCI network cards, and uses pci dma functions.
Most of the pci dma functions are wrappers around other functions which
is what I have used for the platform version. For example:
rd_info->skb_dma = pci_map_single(vptr->pdev, rd_info->skb->data,
is replaced with:
rd_info->skb_dma = dma_map_single(&vptr->plat_dev->dev, rd_info->skb->data,
Is it ok to use the non-pci versions (which are basically just the
unwrapped pci versions) and pass the struct device *, or will I need to
use the correct function for the correct instance.
Other than adding some new probe/remove functions, this is all that is
needed to add platform driver support.
One bug/problem that arose is to do with the EEPROM code in
velocity_init_registers(), in the case for VELOCITY_INIT_COLD:
for (i = 0; i < 6; i++)
I assume this is loading something from an EEPROM, but there is no
EEPROM on the APC8750. Removing this code, the driver seems to work fine
on the APC8750.
Could it be avoided with a vptr->has_no_eeprom that defaults to 0 to
avoid breaking existing support?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/