Re: [PATCH v2] x86: make DR*_RESERVED unsigned long

From: H. Peter Anvin
Date: Sun Apr 28 2013 - 13:33:14 EST

On 04/28/2013 10:27 AM, Oleg Nesterov wrote:
> On 04/28, Frederic Weisbecker wrote:
>> On Sat, Apr 27, 2013 at 04:45:37PM +0200, Oleg Nesterov wrote:
>>> -/* Define reserved bits in DR6 which are always set to 1 */
>>> -#define DR6_RESERVED (0xFFFF0FF0)
>>> +#define DR6_MASK (0xF00FU) /* Everything else is reserved */
>> I'm personally fine either with that or with Peter's suggestion to do:
>> -#define DR6_RESERVED (0xFFFF0FF0)
>> +#define DR6_RESERVED (~0xF00FUL)
> I missed this suggestion...
> Yes, and this allows to kill ifdef too.
>> If this should stay stable UAPI,
> I do not know, but I guess it would be safer to keep the old define's.
>> I really don't mind.
> Oh, I do not mind too ;)
> OK, please see v3.

Looks good. However, given the timing, I would think this is 3.11
material unless we have a manifest bug at this point.

I have several bits like this that I'm going to queue up in a separate
tip branch.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at