Re: [PATCH] perf: powerpc: Fix compile errors in bp_signal files

From: Jiri Olsa
Date: Mon Apr 29 2013 - 05:59:36 EST


On Fri, Apr 26, 2013 at 10:33:21AM -0700, Sukadev Bhattiprolu wrote:
> From 0e27e218def9ae630cc07efbd21664c150a3727a Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> Date: Fri, 26 Apr 2013 10:17:56 -0700
> Subject: [PATCH] perf: powerpc: Fix compile errors in bp_signal files
>
> When building on powerpc, we get compile errors in bp_signal.c and
> bp_signal_overflow.c due to __u64 and '%llx'.
>
> Powerpc, needs __SANE_USERSPACE_TYPES__ to be defined so we pick up
> <asm-generic/int-ll64.h> and define __u64 as unsigned long long.

matches the use in tests/attr.c

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> ---
> tools/perf/tests/bp_signal.c | 6 ++++++
> tools/perf/tests/bp_signal_overflow.c | 6 ++++++
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> index 68daa28..aba0954 100644
> --- a/tools/perf/tests/bp_signal.c
> +++ b/tools/perf/tests/bp_signal.c
> @@ -4,6 +4,12 @@
> * (git://github.com/deater/perf_event_tests)
> */
>
> +/*
> + * Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> + * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> + */
> +#define __SANE_USERSPACE_TYPES__
> +
> #include <stdlib.h>
> #include <stdio.h>
> #include <unistd.h>
> diff --git a/tools/perf/tests/bp_signal_overflow.c b/tools/perf/tests/bp_signal_overflow.c
> index fe7ed28..44ac821 100644
> --- a/tools/perf/tests/bp_signal_overflow.c
> +++ b/tools/perf/tests/bp_signal_overflow.c
> @@ -3,6 +3,12 @@
> * perf_event_tests (git://github.com/deater/perf_event_tests)
> */
>
> +/*
> + * Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> + * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> + */
> +#define __SANE_USERSPACE_TYPES__
> +
> #include <stdlib.h>
> #include <stdio.h>
> #include <unistd.h>
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/