Re: [PATCH] regulator: ab3100: Fix regulator register error handling

From: Linus Walleij
Date: Mon Apr 29 2013 - 08:53:09 EST

On Fri, Apr 26, 2013 at 3:57 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:

> Ensure to unregister all regulators before return error in probe().
> The regulator register order depends on the regulator ID pass to
> ab3100_regulator_register() function. Thus we need to scan ab3100_regulator_desc
> and find the index of successfully registered regulators, or alternatively just
> call ab3100_regulators_remove() to unregister all registered regulators.
> Since current code uses a static ab3100_regulators table, explicitly set
> reg->rdev = NULL after regulator_unregister() call to ensure calling
> ab3100_regulators_remove() in the unwind path always work.
> Also move ab3100_regulators_remove() to avoid forward declaration.
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Excellent patch Axel, thanks!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at