[ 17/30] atm: update msg_namelen in vcc_recvmsg()
From: Greg Kroah-Hartman
Date: Mon Apr 29 2013 - 15:05:17 EST
3.0-stable review patch. If anyone has any objections, please let me know.
From: Mathias Krause <minipli@xxxxxxxxxxxxxx>
[ Upstream commit 9b3e617f3df53822345a8573b6d358f6b9e5ed87 ]
The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.
Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about vcc_recvmsg() not filling the msg_name in case it was set.
Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
net/atm/common.c | 2 ++
1 file changed, 2 insertions(+)
@@ -500,6 +500,8 @@ int vcc_recvmsg(struct kiocb *iocb, stru
struct sk_buff *skb;
int copied, error = -EINVAL;
+ msg->msg_namelen = 0;
if (sock->state != SS_CONNECTED)
if (flags & ~MSG_DONTWAIT) /* only handle MSG_DONTWAIT */
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/