Re: [GIT PATCH] char/misc patches for 3.10-rc1

[Linus Torvalds]

On Mon, Apr 29, 2013 at 12:54 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> I think there are good reasons for most of the drivers we have moved out
> of arch/arm to stay out of there: we have added subdirectories for a lot
> of drivers that are alike:

Maybe. But this one is NOT such a case, and I saw Nico making excuses
for it on lkml.

There are other things wrong with that whole SSBI driver crap that you
seem to be ignoring:

 - it's not a bus, it's just a driver. Just because some people call
it "serial bus" doesn't make it magically about a "bus". I can call an
ethernet driver an "ethernet bus driver", and it may be technically
correct, but it is still bullshit. And ethernet is damn more a real
bus than that SSBI driver is. That's just a pure serial driver for a
very specific piece of embedded hardware. Stop calling it a bus.

 - The whole Kconfig thing is complete and utter garbage. There is no
excuse what-so-ever for ever asking the user about it. Not on x86, not
on ARM. The drivers that actually *use* that magical serial line
driver should just have selected it.

 - I'm not seeing what commonalities this thing can have with anything
else. Did anybody look at the code? There's nothing generic there.

So move it to a saner place, fix the kconfig idiocy, and don't make
noises as if it's some generic driver, much less some generic bus.
It's not.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/