Re: [PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

From: Laurent Pinchart
Date: Mon Apr 29 2013 - 16:34:56 EST


Hi Shawn,

Thank you for the patch.

On Tuesday 23 April 2013 17:42:32 Shawn Nematbakhsh wrote:
> While usb_kill_urb is in progress, calls to usb_submit_urb will fail
> with -EPERM (documented in Documentation/usb/URB.txt). The UVC driver
> does not correctly handle this case -- there is no synchronization
> between uvc_v4l2_open / uvc_status_start and uvc_v4l2_release /
> uvc_status_stop.

Wouldn't it be better to synchronize status operations in open/release ?
Something like the following patch: