Re: [GIT PATCH] char/misc patches for 3.10-rc1
From: David Brown
Date: Mon Apr 29 2013 - 17:08:57 EST
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:
> There are other things wrong with that whole SSBI driver crap that you
> seem to be ignoring:
> - it's not a bus, it's just a driver. Just because some people call
> it "serial bus" doesn't make it magically about a "bus". I can call an
> ethernet driver an "ethernet bus driver", and it may be technically
> correct, but it is still bullshit. And ethernet is damn more a real
> bus than that SSBI driver is. That's just a pure serial driver for a
> very specific piece of embedded hardware. Stop calling it a bus.
Correct. Despite having "bus" in the name, it isn't really a bus. It's
a point-to-point serial interface to a non-addressible device.
> - The whole Kconfig thing is complete and utter garbage. There is no
> excuse what-so-ever for ever asking the user about it. Not on x86, not
> on ARM. The drivers that actually *use* that magical serial line
> driver should just have selected it.
> - I'm not seeing what commonalities this thing can have with anything
> else. Did anybody look at the code? There's nothing generic there.
This driver has one purpose, and will only ever have this one purpose:
to connect the MSM SOC to a small family of power management chips. It
is theoretically possible to connect it to other things, and I think
there have been some obscure designs that do this, but not anything that
is going to be supported in the kernel.
> So move it to a saner place, fix the kconfig idiocy, and don't make
> noises as if it's some generic driver, much less some generic bus.
> It's not.
So, what is this saner place? The hardware is theoretically shared
between ARM and Hexagon, but I don't know the hexagon plans to support
it, I've added them to the CC.
I'm not sure why this shouldn't be in the drivers/mfd directory
alongside the various pm*.c drivers that use it. It isn't going to be
used for anything else.
Given the bikeshedding that happened when Ken pushed the driver out last
time, though, I'm sure this will create a firestorm of disagreement over
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/