Re: [GIT PATCH] USB patches for 3.10-rc1
From: Linus Torvalds
Date: Mon Apr 29 2013 - 17:32:07 EST
On Mon, Apr 29, 2013 at 2:14 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> What other things seemed odd about Greg's pull request?
The only other thing I noticed was the new CONFIG_USB_PHY quesiton,
which is not something that I think is sensible to ask from a user,
and the help text doesn't really help anything either.
I think the question may make sense, but the wording does not.
*EVERYBODY* wants a USB PHY. You can't have USB without a physical
layer unless it's a purely virtual device. There's one in a EHCI
controller too. It's like a network chip - without a PHY there's no
point. Why ask about whether you want to support a phy or not? The
question makes no sense.
So I don't think the question should be "do you want a USB PHY". The
question should be "Do you want a driver for some of the specialized
external USB controllers" or something like that. Because as it is
now, anybody who actually reads the question is likely to answer "y",
I think, even if he just wants one of the *normal* USB chips that
don't split out the PHY.
Hmm? Or does PHY have some magic other meaning in USB circles? In
which case the wording should still be totally redone to not be so
confusing and misleading.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/