Re: [PATCH] dma: tegra: implement suspend/resume callbacks

From: Laxman Dewangan
Date: Tue Apr 30 2013 - 08:47:20 EST

On Tuesday 30 April 2013 04:00 PM, Vinod Koul wrote:
On Wed, Apr 24, 2013 at 03:24:27PM +0530, Laxman Dewangan wrote:
+ /* Enable clock before accessing register */
+ ret = tegra_dma_runtime_resume(dev);
+ if (ret < 0)
+ return ret;
You dont seem to handle suspend when DMA is active? Otherwise looks fine.
Stephen, you okay with this patch?

The client of dma need to gracefully stop the transfer and then do suspend himself.
Also driver suspend can happen even if there is no allocation of dma. In this case, clock is disabled so enabling explicitly here.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at