Re: linux-next build error (at91) - use of bool in mach/arch.h

From: Stefano Stabellini
Date: Tue Apr 30 2013 - 11:59:35 EST


On Tue, 30 Apr 2013, Nicolas Pitre wrote:
> On Tue, 30 Apr 2013, Stefano Stabellini wrote:
>
> > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote:
> > > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@xxxxxxxxx> wrote:
> > > > So, I am wondering if the best correction is to add the types.h header file
> > > > in the asm/mach/arch.h file, like this:
> > > >
> > > > --- a/arch/arm/include/asm/mach/arch.h
> > > > +++ b/arch/arm/include/asm/mach/arch.h
> > > > @@ -8,6 +8,8 @@
> > > > * published by the Free Software Foundation.
> > > > */
> > > >
> > > > +#include <linux/types.h>
> > > > +
> > > > #ifndef __ASSEMBLY__
> > > >
> > > > struct tag;
> > > >
> > > > or if a better option would be to re-arrange the include directives in
> > > > various at91xxx_devices.c files?
> > >
> > > Include files should be self-contained, so asm/mach/arch.h is the right place.
> >
> > Nicolas,
> > are you happy to come up with a proper patch to fix the issue?
>
> I'd prefer if you just folded the above include into the original patch,
> unless this has been pulled already.

No, I'll exploit the opportunity to resend the patch series and issue a
PULL request for the arm-soc tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/