Re: [PATCH] memory hotplug: fix warnings

From: David Rientjes
Date: Tue Apr 30 2013 - 12:17:21 EST


On Tue, 30 Apr 2013, Vincent Stehlà wrote:

> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 73817af..85c31a8 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -137,7 +137,7 @@ enum mem_add_context { BOOT, HOTPLUG };
> #define register_hotmemory_notifier(nb) register_memory_notifier(nb)
> #define unregister_hotmemory_notifier(nb) unregister_memory_notifier(nb)
> #else
> -#define hotplug_memory_notifier(fn, pri) (0)
> +#define hotplug_memory_notifier(fn, pri) ({ 0; })
> /* These aren't inline functions due to a GCC bug. */
> #define register_hotmemory_notifier(nb) ({ (void)(nb); 0; })
> #define unregister_hotmemory_notifier(nb) ({ (void)(nb); })

You can't use the standard do {} while (0)?