Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

[Borislav Petkov]

On Thu, Apr 11, 2013 at 07:45:03AM -0700, Joe Perches wrote:
> CamelCase tests are a bit noisy against certain
> types of code acceptable to some kernel developers.
> 
> Make the test applicable only with --strict.
> 
> Do not bleat a message on nominally acceptable
> CamelCase uses that are separated by an _ like
> drm_core_has_MTRR.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3fb6d86..97226fb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2937,12 +2937,12 @@ sub process {
>  		while ($line =~ m{($Constant|$Lval)}g) {
>  			my $var = $1;
>  			if ($var !~ /$Constant/ &&
> -			    $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> +			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
>  			    $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
>  			    !defined $camelcase{$var}) {
>  				$camelcase{$var} = 1;
> -				WARN("CAMELCASE",
> -				     "Avoid CamelCase: <$var>\n" . $herecurr);
> +				CHK("CAMELCASE",
> +				    "Avoid CamelCase: <$var>\n" . $herecurr);

Yep, this is better.

James?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/