Re: initcall ffh_cstate_init+0x0/0x2a returned with error code -1throws WARN

[Steven Rostedt]

On Wed, 2013-05-01 at 09:48 -0400, Konrad Rzeszutek Wilk wrote:
> Now with the git commit f91eb62f71b31e69e405663ff8d047bc3b9f7525
> (init: scream bloody murder if interrupts are enabled too early)

Perhaps I got a little too aggressive with that patch. The warnings look
to be caused by:

@@ -702,9 +697,7 @@ int __init_or_module do_one_initcall(initcall_t fn)
                strlcat(msgbuf, "disabled interrupts ", sizeof(msgbuf));
                local_irq_enable();
        }
-       if (msgbuf[0]) {
-               printk("initcall %pF returned with %s\n", fn, msgbuf);
-       }
+       WARN(msgbuf[0], "initcall %pF returned with %s\n", fn, msgbuf);
 
        return ret;
 }

I'll just revert that part of the patch, and send that in.

Thanks,

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/