Re: [GIT PATCH] char/misc patches for 3.10-rc1

From: Mark Brown
Date: Wed May 01 2013 - 12:13:50 EST


On Mon, Apr 29, 2013 at 10:50:47PM +0200, Arnd Bergmann wrote:
> On Monday 29 April 2013, Linus Torvalds wrote:

> > - I'm not seeing what commonalities this thing can have with anything
> > else. Did anybody look at the code? There's nothing generic there.

> It's a simple bus that has addressable registers. We have a generic
> infrastructure for these things in drivers/base/regmap, currently
> handling I2C, SPI and MMIO based buses, which are often used as
> different methods to address the same device endpoints. I think it
> would be sensible to add another one-off type here and convert the
> user(s) to be based on the regmap interface rather than its own
> set of exported symbols.

No need for a special bus type, the regmap core now has support for
supplying read and write callbacks so drivers for devices that look
nothing like a bytestream can use the cache and other infrastructure.
This is a good idea anyway for a PMIC since the regulator API has a
large set of regmap based helpers for the standard operations so we'd
probably save a bunch of code in the regulator driver too.

Attachment: signature.asc
Description: Digital signature