Re: [PATCH 00/28] Privatise procfs internals [RFC]

[Geert Uytterhoeven]

On Tue, Apr 16, 2013 at 8:25 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Here is a series of patches to make the procfs internals private to the procfs
> filesystem.  This is built on top of the patches to eliminate
> create_proc_read_entry() after the kill-read_proc_t tag.
>
> These patches include fixes for the places that are attempting to abuse
> proc_dir_entry->count and doing it incorrectly because PID namespaces now
> exist.
>
> All accesses to the PDE struct have been replaced with out-of-line accessor
> functions.  This is a bit less efficient than it used to be, but this could be
> mitigated by using inode->i_private.
>
> The internal procfs structs have moved to fs/procfs/internal.h.  Some of the
> remaining stuff in linux/proc_fs.h has been split out to linux/kcore.h and
> linux/proc_ns.h as they's separate specialised intefaces.

drivers/nubus/proc.c:156:7: error: dereferencing pointer to incomplete type
drivers/nubus/proc.c:158:22: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/nubus/proc.o] Error 1
make[2]: *** [drivers/nubus] Error 2
drivers/zorro/proc.c:142:7: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/zorro/proc.o] Error 1
make[2]: *** [drivers/zorro] Error 2

http://kisskb.ellerman.id.au/kisskb/buildresult/8673100/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/