RE: [PATCH v6 01/16] spi/spi-atmel: fix probing failure afterxfer->speed_hz set

[Yang, Wenyou]

Hi, Joachim,

> -----Original Message-----
> From: Joachim Eastwood [mailto:manabian@xxxxxxxxx]
> Sent: 2013年3月7日 20:31
> To: Yang, Wenyou
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx; Ferre,
> Nicolas; plagnioj@xxxxxxxxxxxx; richard.genoud@xxxxxxxxx; Lin, JM;
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after
> xfer->speed_hz set
> 
> On 7 March 2013 04:26, Wenyou Yang <wenyou.yang@xxxxxxxxx> wrote:
> > commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e
> > cause the atmel spi probing failure.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>
> > Cc: spi-devel-general@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> >  drivers/spi/spi-atmel.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> > index 656d137..1eca815 100644
> > --- a/drivers/spi/spi-atmel.c
> > +++ b/drivers/spi/spi-atmel.c
> > @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi,
> struct spi_message *msg)
> >                         }
> >                 }
> >
> > -               /* FIXME implement these protocol options!! */
> > -               if (xfer->speed_hz) {
> > -                       dev_dbg(&spi->dev, "no protocol options
> yet\n");
> > +               if (xfer->speed_hz < spi->max_speed_hz) {
> > +                       dev_dbg(&spi->dev,
> > +                               "speed in transfer less than bus
> speed\n");
> >                         return -ENOPROTOOPT;
> >                 }
> 
> I sent a similar patch to spi-devl a while ago, which Grant said he applied.
> https://patchwork.kernel.org/patch/2165301/
> 
> Can't find the patch in any upstream git tree so I guess Grant hasn't
> pushed it yet.
This patch hasn't still applied in any upstream git tree, so Atmel spi master doesn't work.
Could you help do some ping it? 

Thanks.

> 
> regards
> Joachim Eastwood

Best Regards,
Wenyou Yang
韬{.n?????%?lzwm?b?Р骒r?zXЩ??{ay????j?f＂?????ア?⒎?:+v???????赙zZ+????"?!?O???v??m?鹈n?帼Y&—