Re: [PATCH] NOHZ, check to see if tick device is initialized in IRQhandling path

[Tony Luck]

>  void tick_nohz_irq_exit(void)
>  {
>         struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
> +       struct clock_event_device *dev =
> +                                    __get_cpu_var(tick_cpu_device).evtdev;
> +
> +       /* Has the tick been initialized yet? */
> +       if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> +               return;

Could we have something in the "struct tick_sched" to tell us whether
it has been set up? Rather than this somewhat convoluted digging
around in the clock_event_device innards?

> +       if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> +               return;

Ditto here.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/