Re: [PATCH 1/4] Driver core: Add offline/online device operations

From: Toshi Kani
Date: Thu May 02 2013 - 19:36:23 EST


On Fri, 2013-05-03 at 01:36 +0200, Rafael J. Wysocki wrote:
> On Thursday, May 02, 2013 05:11:27 PM Toshi Kani wrote:
> > On Thu, 2013-05-02 at 14:27 +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
:
> > >
> > > +static inline bool device_supports_offline(struct device *dev)
> >
> > Since we renamed "offline" to "hotplug" for the lock interfaces, should
> > this function be renamed to device_supports_hotplug() as well?
>
> Well, "offline" is more specific, as there may be devices that don't
> support offline/online, but support hotplug otherwise. That's why I didn't
> change it.

I see. That makes sense.

Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/