Re: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessaryplatform_set_drvdata()

[Srinidhi Kasagar]

On Fri, May 03, 2013 at 08:24:24 +0200, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-ab8500.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 63cfa31..c5b62d4 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
>  {
>  	ab8500_sysfs_rtc_unregister(&pdev->dev);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
Ok, thanks. Hope you have taken care for the ab3100 too...

Acked-by:srinidhi kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx>

regards/srinidhi 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/