Re: [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata()

[Xuetao Guan]

> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Thanks.

Acked-by: Guan Xuetao <gxt@xxxxxxxxxxxxxxx>

> ---
>  drivers/rtc/rtc-puv3.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 72f4371..402732c 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device
> *dev)
>  {
>  	struct rtc_device *rtc = platform_get_drvdata(dev);
>
> -	platform_set_drvdata(dev, NULL);
>  	rtc_device_unregister(rtc);
>
>  	puv3_rtc_setpie(&dev->dev, 0);
> --
> 1.7.2.5
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/