Re: [git pull] GPIO for v3.10

[Grant Likely]

On Fri, May 3, 2013 at 5:14 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> The one-liner commit that enables this piece of shit is signed off by
> two people, has another person with a "Reviewed-by:" and there is no
> way in hell it was ever tested or anybody has ever looked at the
> driver in question. WTF?
>
> I'm going out on a limb here, and guessing that it wasn't in linux-next either.

It's been in linux-next since April 29. The problem is that it depends
on the following commit which is in the mfd tree, which gets merged
into linux-next before the gpio tree. The following commit removes the
prototype that it breaks on. That is why linux-next didn't catch it,
but it doesn't change the fact that it never should have been
committed that way.

commit 360e64d8bbe7c78784d769a60d152804f5079577
Author: Marek Vasut <marex@xxxxxxx>
Date:   Sun Apr 14 20:35:48 2013 +0200

    mfd: ucb1400: Pass ucb1400-gpio data through ac97 bus

    Cc: Jean Delvare <jdelvare@xxxxxxx>
    Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
    Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
    Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
    Reviewed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Marek Vasut <marex@xxxxxxx>
    Signed-off-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>

And, no, I didn't do a full build test of that tree before sending it.
Linusw has been a huge help and offloaded a bunch of the gpio work and
keeping on top of the gpio driver patches. Not his fault though, I got
lazy seeing that it had already been in linux next and so didn't build
everything.

> Quite frankly, I'm not taking any GPIO changes from you this merge
> window. I only noticed this after having done two other merges on top
> of it, so now I'll have to go back and undo all of this, because quite
> frankly, I'm upset enough that I don't want to have any remains of
> this whole experience in my tree.

Very well. I do apologize am sorry for causing you extra work. There
is another series of GPIO changes that removes GENERIC_GPIO. Alex
Courbot has done all the leg work of getting them prepared, dealing
with the cross-tree conflicts and getting it into linux-next for
testing. That branch is completely separate from the other GPIO
changes. I'll get him to send you the pull request directly and you
can decide whether or not to pull it.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/