[PATCH 06/33] blk-throttle: remove spurious throtl_enqueue_tg() call from throtl_select_dispatch()

From: Tejun Heo
Date: Mon May 06 2013 - 18:54:20 EST


throtl_select_dispatch() calls throtl_enqueue_tg() right after
tg_update_disptime(), which always calls the function anyway. The
call is, while harmless, unnecessary. Remove it.

This patch doesn't introduce any behavior difference.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
---
block/blk-throttle.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 3114622..3960787 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -816,10 +816,8 @@ static int throtl_select_dispatch(struct throtl_data *td, struct bio_list *bl)

nr_disp += throtl_dispatch_tg(td, tg, bl);

- if (tg->nr_queued[0] || tg->nr_queued[1]) {
+ if (tg->nr_queued[0] || tg->nr_queued[1])
tg_update_disptime(td, tg);
- throtl_enqueue_tg(td, tg);
- }

if (nr_disp >= throtl_quantum)
break;
--
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/