Re: [PATCH] menuconfig: fix NULL pointer dereference when searchinga symbol

From: Yann E. MORIN
Date: Tue May 07 2013 - 09:22:11 EST

Next message: Wei Yongjun: "[PATCH] drm/exynos: fix error return code in exynos_drm_ipp_set_property()"
Previous message: Syed Salman Mansoor: "[PATCH] x86, setup: Removed spaces, trailing character and suspect code indent warnings and errors in a20.c This is a patch to the a20.c file that fixes following warnings/errors found by the checkpatch.pl tool i) WARNING: please, no spaces at the start of a line ii) WARNING: suspect code indent for conditional statements iii) ERROR: trailing whitespace"
In reply to: Borislav Petkov: "Re: [PATCH] menuconfig: fix NULL pointer dereference when searchinga symbol"
Next in thread: Michal Marek: "Re: [PATCH] menuconfig: fix NULL pointer dereference when searchinga symbol"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Li, All,

On Tue, May 07, 2013 at 10:40:59AM +0800, Li Zefan wrote:
> Searching PPC_EFIKA results segmentation fault, and it's because
> get_symbol_prop() returns NULL.
>
> In this case CONFIG_PPC_EFIKA is defined in arch/powerpc/platforms/
> 52xx/Kconfig, so it won't be parsed if ARCH!=PPC, but menuconfig
> knows this symbol when it parses sound/soc/fsl/Kconfig:
>
> config SND_MPC52xx_SOC_EFIKA
> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
> depends on PPC_EFIKA
>
> This bug was introduced by commit bcdedcc1afd6 ("menuconfig: print more
> info for symbol without prompts").
>
> Reported-by: Borislav Petkov <bp@xxxxxxxxx>
> Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>

Michal, I'll get this in my tree, and will send a pull-request to you
later (I may have a few other smallish fixes shortly).

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/