Re: [PATCH] rtc: rtc-tile: add missing platform_device_unregister()when module exit

[Andrew Morton]

On Sun, 5 May 2013 13:07:00 +0800 Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:

> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> We have registered platform device when module init, and
> need unregister it when module exit.
> 
> ...
>
> --- a/drivers/rtc/rtc-tile.c
> +++ b/drivers/rtc/rtc-tile.c
> @@ -146,6 +146,7 @@ exit_driver_unregister:
>   */
>  static void __exit tile_rtc_driver_exit(void)
>  {
> +	platform_device_unregister(tile_rtc_platform_device);
>  	platform_driver_unregister(&tile_rtc_platform_driver);
>  }

We don't need to do a platform_device_put(), as tile_rtc_driver_init()
does?

drivers/rtc/rtc-stmp3xxx.c appears to need the same fix.

  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/