Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration

[Lee Jones]

On Wed, 08 May 2013, Mark Brown wrote:

> On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote:
> > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
> > the actual one used by STE.  Also update a wrong comment in the process.
> 
> This seems wrong, the individual chip drivers should just be doing
> whatever they're being told by the machine driver.  Sounds like there's
> two fixes needed here - one is to change the TDM API so that the chip
> drivers are just implementing configuration supplied by the machine
> driver and the other is to change the configuration being done to
> whatever is desired.

Do you mean that the original implementation is incorrect, or that
this patch is doing the wrong thing? I think this patch is a bugfix
rather than a opportunity to refactor the driver.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/