Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

[Mark Brown]

On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote:
> On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote:

> > But why does the rest of the code work well if the reference counting is
> > wrong, it's in the middle of a big block of code?  This all smells like
> > this change is papering over a specific symptom of some underlying issue
> > - if that's not the case then it needs to be clearer why.

> Well, the counting by itself is not wrong, it's just that the same pins
> are used by both driver instances (ux500-msp-i2s.1 and ux500-msp-i2s.3)
> but the actual counter is specific of each instance
> (msp->pinctrl_rxtx_ref, if I'm not mistaken msp is different between the
> capture and playback interfaces).

So if these pins are being shared between the instances then surely
there are other interdependencies that need to be taken care of Is that
happening?  For example if the clocks are shared then is the code
currently stopping the interfaces being configured with incompatible
sample rates or word sizes?

It seems like the code is definitely buggy here but is this really all
that's buggy or is it just the symptom you happen to have seen?

> Ok, what I'm trying to say is that the codec used in this platform
> should be able to handle sleep modes without requiring any
> reconfiguration of the digital interface on the SoC side.  In support of
> this the fact that the STE fork of the driver does not do that, and the
> same goes for all other ASoC drivers currently in mainline.

Well, most things would probably be able to get some small benefit from
doing this, it's just that we've not had any real support for managing
pin muxing - one of the goals of adding pinctrl is to make it easier to
deploy this sort of thing.

Attachment: signature.asc
Description: Digital signature