Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpagesand simplify mem_init()

[Sergei Shtylyov]

Hello.

On 08-05-2013 19:51, Jiang Liu wrote:

> Prepare for removing num_physpages and simplify mem_init().

> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>   arch/h8300/mm/init.c |   34 ++++++++--------------------------
>   1 file changed, 8 insertions(+), 26 deletions(-)

> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
> index 22fd869..0088f3a 100644
> --- a/arch/h8300/mm/init.c
> +++ b/arch/h8300/mm/init.c
> @@ -121,40 +121,22 @@ void __init paging_init(void)
>
>   void __init mem_init(void)
>   {
> -	int codek = 0, datak = 0, initk = 0;
> -	/* DAVIDM look at setup memory map generically with reserved area */
> -	unsigned long tmp;
> -	extern unsigned long  _ramend, _ramstart;
> -	unsigned long len = &_ramend - &_ramstart;
> -	unsigned long start_mem = memory_start; /* DAVIDM - these must start at end of kernel */
> -	unsigned long end_mem   = memory_end; /* DAVIDM - this must not include kernel stack at top */
> +	unsigned long codesize = _etext - _stext;
>
>   #ifdef DEBUG
> -	printk(KERN_DEBUG "Mem_init: start=%lx, end=%lx\n", start_mem, end_mem);
> +	pr_debug("Mem_init: start=%lx, end=%lx\n", memory_start, memory_end);
>   #endif

    pr_debug() only prints something if DEBUG is #define'd, so you can 
drop the #ifdef here.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/