Re: [PATCH -v8 11/11] Move arch/x86 reboot= handling to generickernel.

From: Russell King - ARM Linux
Date: Wed May 08 2013 - 14:23:46 EST


On Tue, May 07, 2013 at 09:39:55AM -0500, Robin Holt wrote:
> + case 's':
> + reboot_mode = REBOOT_WARM;
> + case 'h':
> + reboot_mode = REBOOT_COLD;
> + case 'g':
> + reboot_mode = REBOOT_GPIO;

Further to Ingo's comments, also note that the above is broken. Any
of s,h,g will result in REBOOT_GPIO being set which is clearly wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/