Re: [RFC 3/8] mfd:syscon: Introduce claim/read/write/release APIs
From: Mark Brown
Date: Thu May 09 2013 - 05:52:44 EST
On Wed, May 08, 2013 at 06:42:04PM +0100, Srinivas KANDAGATLA wrote:
Fix your mailer to word wrap within paragraphs.
> Ultimately the syscon_write use the regmap_update_bits, however we
> really want is the flexibility in using/referring the syscon
> registers/bits in both device-trees and non-device tree cases.
So what you're looking for here is some way to offload discovery of
register fields from the driver?
> The reason for these APIs, is the extent of syscon usage is very high
> in ST set-top-box parts.
> Without these new APIs, its very difficult to pass this information to
> the drivers.
I'm not 100% convinced that putting all this information into DT is a
good idea, and to the extent that it is sensible it feels like something
which might be useful with any device using register maps, not just
syscon. For example many MFDs have similar needs - essentially the
system controllers are just a particular kind of MFD. To me that says
that this should be outside syscon so other things can use it.
Attachment:
signature.asc
Description: Digital signature