RE: [PATCH] aerdrv: Move cper_print_pcie() out of interrupt context

[Ortiz, Lance E]

Rafael,  

Thanks for your feedback.

> The way the changes are described here isn't particularly clear to me.

I will try to make it a little more clear.


> Also, since aer_recover_work_func() is going to be the only existing
> caller of
> cper_print_aer() after this change, as far as I can say, and it doesn't
> use the
> function's first argument, that argument should be dropped entirely.

The truth is, the function cper_print_aer() really needs to be re-written so it is consistent with aer_print_error() in how it outputs information.  Right now, the output is formatted very differently.  I was planning on doing that at a later date, but fix the warning now.  I might add a TODO comment in the code for this.

The reason I did not remove the argument in cper_print_aer() is because 'prefix' is used in the call to cper_print_bits(), and I passed through an empty string to make sure that function worked correctly.  I can try to clean it up.

Lance
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_