Re: [PATCH] perf tools: Fix perf version generation

[Robert Richter]

On 08.05.13 22:01:01, Runzhen Wang wrote:
> # ./perf --version
> perf version 3.9.1
> 
> your patch works when the repo only has commit info but no tags
> info, but I confuse that whether this situation is Real?
> 
> Maybe you prepare for a RARE case but increase the code's **Complexity** ?

It works in both cases. And the complexity is also handled for kernel
versioning, see scripts/setlocalversion:

 # If we don't have a tag at all we print -g{commitish}.

I also considered to reuse scripts/setlocalversion, but it turned out
to require too much changes for perf version generation.

-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/