Re: [PATCH -v10 09/11] arm, prepare reboot_mode for moving togeneric kernel code.

[Russell King - ARM Linux]

On Sat, May 11, 2013 at 06:57:25AM -0500, Robin Holt wrote:
> This patch prepares for the moving the parsing of reboot= to the generic
> kernel code by making reboot_mode into a more generic form.
> 
> Signed-off-by: Robin Holt <holt@xxxxxxx>
> To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> To: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Russ Anderson <rja@xxxxxxx>
> Cc: Robin Holt <holt@xxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Guan Xuetao <gxt@xxxxxxxxxxxxxxx>
> Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: the arch/x86 maintainers <x86@xxxxxxxxxx>
> Cc: Arm Mailing List <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>

Almost-but-not-quite-Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> :)

> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f219703..92b47df 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -174,14 +174,14 @@ void arch_cpu_idle(void)
>  		default_idle();
>  }
>  
> -static char reboot_mode = 'h';
> +enum reboot_mode reboot_mode = REBOOT_HARD;
>  
> -int __init reboot_setup(char *str)
> +static int __init reboot_setup(char *str)
>  {
> -	reboot_mode = str[0];
> +	if ('s' == str[0])
> +		reboot_mode = REBOOT_SOFT;

Remember we talked about the 'gpio' mode as well, so you also need here
+	if ('g' == str[0])
		reboot_mode = REBOOT_GPIO;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/