Re: [PATCH] mmc: core: Add a capability for disabling mmc cards

[Linus Walleij]

On Tue, May 14, 2013 at 9:38 AM, Adam Lee <adam.lee@xxxxxxxxxxxxx> wrote:

> On some systems we need a way to disable MMC card support in a MMC/SD
> card slot due to the legal concern.
>
> Add support in the core SD/MMC code to support this.
>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Signed-off-by: Adam Lee <adam.lee@xxxxxxxxxxxxx>

(...)
>  #define MMC_CAP2_NO_PRESCAN_POWERUP (1 << 14)  /* Don't power up before scan */
> +#define MMC_CAP2_NO_MMC                (1 << 15)       /* Only SD supported, not MMC */

I would name that MMC_CAP2_DISABLE_MMC_BUT_NOT_SD
because that is what it means.

People wanting to set that capability for said legal reasons
will not read the git log.

So also encode what you just said in the comment for the CAP
so it is crystal clear what this is for.

I'm a bit ambivalent about what kind of benefits this provides
to human users of the Linux kernel, while I do understand the
benefit it provides for legal bodies...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/