Re: [PATCH 8/9] perf report: Add report.percent-limit config variable

From: Pekka Enberg
Date: Tue May 14 2013 - 07:05:43 EST


On Tue, May 14, 2013 at 5:09 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> Now an user can set a default value of --percent-limit option into the
> perfconfig file.
>
> $ cat ~/.perfconfig
> [report]
> percent-limit = 0.1
>
> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Cc: Pekka Enberg <penberg@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

I'm not totally convinced this is useful. The limit is about "what is
significant" and that depends on what you are trying to measure.
There's an (absolute) lower limit somewhere between 0.1 and 1.0 but I
think we can just pick a reasonable default and let people use the
command line switch if they want to override it.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/