Re: [PATCH] x86: add a new SMP bring up way for tboot case

[H. Peter Anvin]

On 05/14/2013 02:21 PM, Qiaowei Ren wrote:
> tboot provides a better AP wakeup mechanism based on cpu MWAIT
> feature for OS/VMM. With this mechanism, system will boot faster
> and will NOT require VT to be enabled. But it requires that
> OS/VMM must have support it, otherwise system can never boot up.
> 
> Once this mechanism is enabled, tboot will put APs waiting in
> MWAIT loops before launching kernel. kernel can check the new
> flag field in v6 tboot shared page for the hint. If the bit
> TB_FLAG_AP_WAKE_SUPPORT in flag field is set, kernel BSP has
> to write the monitored memory (tboot->ap_wake_trigger) to bring
> APs out of MWAIT loops. The sipi vector should be written in
> tboot->ap_wake_addr before waking up APs.
> 

This really needs a *detailed* specification about the state the CPU is
parked in.  Most BIOSes do in fact park the CPUs in an mwait loop, but
we can't use it because the CPU state they are parked in is ill-defined.

This is a good idea, but please write (or point to) a spec about what
the parked CPU state looks like and how the OS gets control.  From the
*looks* of the code I assume it is entered in 16-bit real mode but then
it is important to know what parts of the register state are well-defined.

> +#define TB_FLAG_AP_WAKE_SUPPORT 0X00000001

Minor nit: please lower-case the hexadecimal x.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/