Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

[Bryan Wu]

On Tue, May 14, 2013 at 12:06 AM, Christian Gmeiner
<christian.gmeiner@xxxxxxxxx> wrote:
> 2013/5/12 Christian Gmeiner <christian.gmeiner@xxxxxxxxx>:
>> 2013/3/8 Christian Gmeiner <christian.gmeiner@xxxxxxxxx>:
>>> 2013/3/5 Bryan Wu <cooloney@xxxxxxxxx>:
>>>> On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner
>>>> <christian.gmeiner@xxxxxxxxx> wrote:
>>>>> ping
>>>>> --

I found this patch is still in linux-next, I'm not sure whether it
will be merged into 3.10 like a bug fixing. We need to wait Andrew's
reply. I'm OK to pick up and send out to Linus as a bug fixing.

Thanks,
-Bryan

>>>>> Christian Gmeiner, MSc
>>>>>
>>>>>
>>>>> 2013/2/23 Christian Gmeiner <christian.gmeiner@xxxxxxxxx>:
>>>>>> 2013/2/15 Bryan Wu <cooloney@xxxxxxxxx>:
>>>>>>> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner
>>>>>>> <christian.gmeiner@xxxxxxxxx> wrote:
>>>>>>>> During the development of this driver an in-house register
>>>>>>>> documentation was used. The last weeks some integration tests
>>>>>>>> were done and this problem was found. It turned out that
>>>>>>>> the released register documentation is wrong.
>>>>>>>>
>>>>>>>> The fix is very simple: shift all masks by one.
>>>>>>>>
>>>>>>>> Our customers can control LEDs from userspace via Java,
>>>>>>>> C++ or what every. They have running/working applications where
>>>>>>>> they want to control led_3 but led_2 get's used.
>>>>>>>> I got a bug report in our in-house bug tracker so it would be
>>>>>>>> great to fix this upstream.
>>>>>>>>
>>>>>>>> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
>>>>>>>
>>>>>>> Thanks, Christian.
>>>>>>>
>>>>>>> And Andrew, are you going to take care of this patch? Or I will merge this.
>>>>>>>
>>>>>>
>>>>>> Whats the current state of the patch? Hope we can get it into 3.9 :)
>>>>>>
>>>>
>>>> I think this patch is already in linux-next via Andrew's tree (commit
>>>> 023206171f235f93f26c314f76f5405a3077aaba). So it will be merged into
>>>> 3.10 I guess, but not 3.9.
>>>>
>>>> Or I can send out this patch to Linus as a fix and ask Andrew to drop
>>>> this from his tree.
>>>>
>>>
>>> I am fine with the current situation and 3.10 is fine too.
>>>
>>
>> 3.10-rc1 is out but my patch is missing. What happened?
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?id=refs%2Ftags%2Fv3.10-rc1&qt=author&q=gmeiner
>>
>
> ping
> --
> Christian Gmeiner, MSc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/