On Fri, 2013-04-26 at 17:08 +0800, Huang Shijie wrote:Ok, Please drop the 3 patches.Add more commit for ecc_strength and ecc_size fields.Huang, let me drop the 3 patches I already merged. Please, re-send them
We can treat the comment as the initial semantics for the two fields.
Signed-off-by: Huang Shijie<b32955@xxxxxxxxxxxxx>
in v5. I think this is better because I see you start applying patches
on top of them, which is a bit confusing.
it's okay to me.* @cellinfo: [INTERN] MLC/multichip data from chip identI find this confusing still. How about this comment.
* @ecc_strength: [INTERN] ECC correctability from the datasheet.
+ * The minimum number of bits correctability, if known;
+ * if unknown, set to 0.
ECC correctability from the datasheet. Minumum amount of bit errors per
@ecc_size guaranteed to be correctable). If unknown, set to zero.
In nand_ecc_ctrl{}, the ecc step is named to @size.* @ecc_size: [INTERN] ECC size required by the @ecc_strength,Silly question, why you call this one "ecc_size", and not "ecc_step"?
- * also from the datasheet.
+ * also from the datasheet. It is the recommended ECC step
+ * size, if known; if unknown, set to 0.