Re: [RFC/PATCH 1/2] perf script: Add --time-filter option

[David Ahern]

On 5/15/13 7:56 PM, Namhyung Kim wrote:
> > How about just --time? less typing.
>
> Thanks, I'm fine with '--time' too but '--time-filter' looks more

yes, I just have really long command lines now. Is there a consistent 
single letter (X?)?

> obvious.  What does the timehist command do, btw? ;)

task scheduling time history including run time and time between 
sched-in. It needs to be updated to use tracepoints and perhaps fold 
into perf-sched (e.g., perf sched history). Too many features; too 
little time. I hope to get to it in the next month or so.


> > I would expect parse_nsec_time to fail. e.g., a time string like 123455.a
>
> It looks like current strtol() returns 0 when failed to parse like
> above.  Hmm.. do I have to check whether the return value is 0 or just
> ignore invalid inputs?

end will point to the next character not converted so make sure it is as 
expected (*end == '\0').

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/