Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support

[Greg KH]

On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote:
> +/*
> + * Retrieve the (sub) channel on which to send an outgoing request.
> + * When a primary channel has multiple sub-channels, we choose a
> + * channel whose VCPU binding is closest to the VCPU on which
> + * this call is being made.
> + */
> +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel *primary)

That's a _very_ vague global symbol name you are adding to the kernel.
Same goes for the other functions you are adding here, please fix that,
and make them have the vmbus_ prefix, like everything else in this
patch.

So, sorry, no ack here.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/