Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

[Leon Romanovsky]

Hi Samuel,

On Wed, May 15, 2013 at 12:19 PM, Leon Romanovsky <leon@xxxxxxx> wrote:
> There is no need to call kfree while using devm_kzalloc,
> remove it from *_device_init function.
>
> Signed-off-by: Leon Romanovsky <leon@xxxxxxx>
> ---
>  drivers/mfd/tps65912-core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

To be honest the whole tps65912 looks strange to me.
For example,  kfree(tps65912) calls all over the code.

tps65912_i2c_probe allocates tps65912 struct, but tps65912_device_exit
releases it.


--
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/