Re: [PATCH v2 1/2] Make the batch size of the percpu_counterconfigurable

From: Andrew Morton
Date: Wed May 29 2013 - 17:34:19 EST


On Wed, 29 May 2013 14:20:12 -0700 Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> wrote:

> > Do we have any performance testing results? They're pretty important
> > for a performance-improvement patch ;)
> >
>
> I've done a repeated brk test of 800KB (from will-it-scale test suite)
> with 80 concurrent processes on a 4 socket Westmere machine with a
> total of 40 cores. Without the patch, about 80% of cpu is spent on
> spin-lock contention within the vm_committed_as counter. With the patch,
> there's a 73x speedup on the benchmark and the lock contention drops off
> almost entirely.

Only a 73x speedup? I dunno what they pay you for ;)

How serious is this performance problem in real-world work? For
something of this magnitude we might want to backport the patch into
earlier kernels (because most everyone who uses those kernels will be
doing this anyway). However such an act would require a pretty clear
explanation of the benefit which end-users will see.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/