Re: [PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"

[Felipe Balbi]

On Sat, Jun 01, 2013 at 11:36:46AM +0200, Thomas Meyer wrote:
> 

-ENOLOG

please add a commit log.

> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---
> 
> diff -u -p a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -3046,11 +3046,10 @@ static int __init lpc32xx_udc_probe(stru
>  	dma_addr_t dma_handle;
>  	struct device_node *isp1301_node;
>  
> -	udc = kzalloc(sizeof(*udc), GFP_KERNEL);
> +	udc = kmemdup(&controller_template, sizeof(*udc), GFP_KERNEL);
>  	if (!udc)
>  		return -ENOMEM;
>  
> -	memcpy(udc, &controller_template, sizeof(*udc));
>  	for (i = 0; i <= 15; i++)
>  		udc->ep[i].udc = udc;
>  	udc->gadget.ep0 = &udc->ep[0].ep;
> 
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature