Re: [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code
From: Tushar Behera
Date: Mon Jun 03 2013 - 00:18:38 EST
On 06/01/2013 02:11 PM, Sylwester Nawrocki wrote:
> Hi,
>
> On 05/31/2013 01:49 PM, Tushar Behera wrote:
>> The uncompress code in S5P64X0 is almost same as the uncompress code
>> defined in plat-samsung. Better to reuse that code.
>>
>> Signed-off-by: Tushar Behera<tushar.behera@xxxxxxxxxx>
>> ---
>> arch/arm/mach-s5p64x0/include/mach/uncompress.h | 163
>> ++---------------------
>> 1 file changed, 8 insertions(+), 155 deletions(-)
>
> Not sure if you are aware of it, Tomasz has already posted a patch that
> removes this duplicated code: https://patchwork.kernel.org/patch/2589331
> I think that patch is not yet merged though.
>
> Regards,
> Sylwester
Tomasz,
I had somehow missed that mail.
The patch that I have additionally makes calculation of uart_base
conditional on DEBUG_LL in line with the rest of the patches.
Would you mind re-spining your patch with those changes?
Alternately, I can take your patch and do above modifications in them.
Let me know your opinion on this.
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/