Re: [PATCH 2/2] mfd: ssbi: Use devm_* to simplify code

[Lee Jones]

> Use devm_ioremap_resource and devm_kzalloc to simplify error
> paths and reduce lines of code.

The code looks fine, but you're actually doing a great deal more than
you describe in the commit message. Would you mind expanding?

I.e:

> +		dev_err(&pdev->dev, "Unknown qcom,controller-type\n");

Switching to these 'cos they're more informative.

> -	platform_set_drvdata(pdev, NULL);

Removing these because they're obsolete.

> -	.remove		= ssbi_remove,

Removing this 'cos it no longer does anything useful.

> +module_platform_driver(ssbi_driver);

Moving these because it's more succinct when init() and exit()
routines are baron.

None of the above have anything to do with devm_* managed resources.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/