Re: [char-misc 3.10] mei: nfc: fix nfc device freeing

From: Greg KH
Date: Mon Jun 03 2013 - 10:26:36 EST


On Mon, Jun 03, 2013 at 09:28:30AM +0300, Tomas Winkler wrote:
> The nfc_dev is a static variable and is not cleaned properly upon reset
> mainly ndev->cl and ndev->cl_info are not set to NULL after freeing which

Then it needs to be made dynamic, don't paper over the bug by zeroing it
out, you really have a much larger issue here that just hasn't hit you
yet.

No 'struct device' should ever be in a static variable, please fix this
properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/