Re: [PATCH RFC V9 2/19] x86/ticketlock: Don't inline _spin_unlockwhen using paravirt spinlocks

From: Konrad Rzeszutek Wilk
Date: Mon Jun 03 2013 - 11:30:35 EST


On Sun, Jun 02, 2013 at 12:52:09AM +0530, Raghavendra K T wrote:
> x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks
>
> From: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
>
> The code size expands somewhat, and its better to just call
> a function rather than inline it.
>
> Thanks Jeremy for original version of ARCH_NOINLINE_SPIN_UNLOCK config patch,
> which is simplified.
>
> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> arch/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 685692c..80fcc4b 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -621,6 +621,7 @@ config PARAVIRT_DEBUG
> config PARAVIRT_SPINLOCKS
> bool "Paravirtualization layer for spinlocks"
> depends on PARAVIRT && SMP
> + select UNINLINE_SPIN_UNLOCK
> ---help---
> Paravirtualized spinlocks allow a pvops backend to replace the
> spinlock implementation with something virtualization-friendly
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/