Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on eitherUSB or MMC

[Greg Kroah-Hartman]

On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> The gdm72xx driver needs to have either the USB or SDIO implementation
> enabled to provide useful functionalities, so the driver should depend
> on either USB or MMC.
> 
> Signed-off-by: Ben Chan <benchan@xxxxxxxxxxxx>
> Cc: Sage Ahn <syahn@xxxxxxxxxxx>
> ---
>  drivers/staging/gdm72xx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> index 6905913..8af0dd4 100644
> --- a/drivers/staging/gdm72xx/Kconfig
> +++ b/drivers/staging/gdm72xx/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig WIMAX_GDM72XX
>  	tristate "GCT GDM72xx WiMAX support"
> -	depends on NET
> +	depends on NET && (USB || MMC)

Alan Stern already told you how this would not solve the problem, why
did you resend it to me again?

And you forgot the "Reported-by:" line above, giving proper credit to
the person who told you about this problem.

Please fix both of them and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/