Re: [PATCH 2/8] vtime: Use consistent clocks among nohz accounting

[Frederic Weisbecker]

On Mon, Jun 03, 2013 at 11:47:17AM +0200, Stefan Seyfried wrote:
> Am 20.05.2013 18:01, schrieb Frederic Weisbecker:
> > While computing the cputime delta of dynticks CPUs,
> > we are mixing up clocks of differents natures:
> 
> [...]
> 
> > As a consequence, some strange behaviour with unstable tsc
> > has been observed such as non progressing constant zero cputime.
> > (The 'top' command showing no load).
> 
> This happens for example on my trusty ThinkPad X200s (family 6 model 23
> stepping 10 Core 2 duo), seriously confusing its user (me :-).
> 
> > Fix this by only using local_clock(), or its irq safe/remote
> > equivalent, in vtime code.
> > 
> > Reported-by: Mike Galbraith <efault@xxxxxx>
> > Suggested-by: Mike Galbraith <efault@xxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Li Zhong <zhong@xxxxxxxxxxxxxxxxxx>
> > Cc: Mike Galbraith <efault@xxxxxx>
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> 
> FWIW:
> Tested-by: Stefan Seyfried <seife+dev@xxxxxxxxxxxxxx>
> 
> This patch fixes the 0% CPU issue on openSUSE Factory kernels for me.

Thanks! The patch has been committed already so I can't add your Tested-by:
but feedbacks on testing are always appeciated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/